[Mesa-dev] [Bug 85869] Offscreen rendering to pixmap EGLSurface is odd

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 5 04:34:13 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=85869

--- Comment #2 from Tapani Pälli <lemody at gmail.com> ---
bisected to:
---- 8< ----
commit 8f55174fbdc27076f310c4dfb1f87072588b8b0b
Author: Kristian Høgsberg <krh at bitplanet.net>
Date:   Fri Aug 15 23:19:52 2014 -0700

    meta: Make MESA_META_DRAW_BUFFERS restore properly

    A meta begin/end pair with MESA_META_DRAW_BUFFERS will change visible GL
    state.  We recreate the draw buffer enums from the buffer bitfield, which
    changes GL_BACK to GL_BACK_LEFT (and GL_FRONT to GL_FRONT_LEFT).

    This commit modifes the save/restore logic to instead copy the buffer enums
    from the gl_framebuffer and then set them on restore using
    _mesa_drawbuffers().

    It's not clear how this breaks the benchmark in 82796, but fixing meta to
not
    leak the state change fixes the regression.

    No piglit regressions.

    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=82796
    Signed-off-by: Kristian Høgsberg <krh at bitplanet.net>
    Cc: mesa-stable at lists.freedesktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141105/383f9242/attachment.html>


More information about the mesa-dev mailing list