[Mesa-dev] [PATCH 1/9] scons: Remove dead code/comments.

[Brian Paul]

The series LGTM.  Reviewed-by: Brian Paul <brianp at vmware.com>


On 11/26/2014 11:47 AM, jfonseca at vmware.com wrote:
> From: José Fonseca <jfonseca at vmware.com>
>
> - Remove no-op if-clause.
>
> - -mstackrealign has been enabled again on MinGW for quite some time and
>    appears to work alright nowadays.
>
> - Drop -mmmx option as it is implied my -msse, and we don't use MMX
>    intrinsics anyway.
> ---
>   scons/gallium.py | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/scons/gallium.py b/scons/gallium.py
> index 4df6e1a..fe800fa 100755
> --- a/scons/gallium.py
> +++ b/scons/gallium.py
> @@ -378,21 +378,18 @@ def generate(env):
>                   #'-march=pentium4',
>               ]
>               if distutils.version.LooseVersion(ccversion) >= distutils.version.LooseVersion('4.2') \
> -               and (platform != 'windows' or env['build'] == 'debug' or True) \
>                  and platform != 'haiku':
>                   # NOTE: We need to ensure stack is realigned given that we
>                   # produce shared objects, and have no control over the stack
>                   # alignment policy of the application. Therefore we need
>                   # -mstackrealign ore -mincoming-stack-boundary=2.
>                   #
> -                # XXX: -O and -mstackrealign causes stack corruption on MinGW
> -                #
>                   # XXX: We could have SSE without -mstackrealign if we always used
>                   # __attribute__((force_align_arg_pointer)), but that's not
>                   # always the case.
>                   ccflags += [
>                       '-mstackrealign', # ensure stack is aligned
> -                    '-mmmx', '-msse', '-msse2', # enable SIMD intrinsics
> +                    '-msse', '-msse2', # enable SIMD intrinsics
>                       #'-mfpmath=sse',
>                   ]
>               if platform in ['windows', 'darwin']:
>