[Mesa-dev] [PATCH] i965: Fix assertion in brw_reg_type_letters

Ben Widawsky benjamin.widawsky at intel.com
Fri Nov 28 14:32:28 PST 2014

While using various debugging features (optimization debug, instruction dumping,
etc) this function is called in order to get a readable letter for the type of

On GEN8, two new units were added, the Qword and the Unsigned Qword (Q, and UQ
respectively). The existing assertion tries to determine that the argument
passed in is within the correct boundary, however, it was using UQ as the upper
limit instead of Q.

To my knowledge you can only hit this case with the branch I am currently
working on, so it doesn't fix any known issues.

Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
 src/mesa/drivers/dri/i965/brw_eu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_eu.c b/src/mesa/drivers/dri/i965/brw_eu.c
index 9905972..cc5f000 100644
--- a/src/mesa/drivers/dri/i965/brw_eu.c
+++ b/src/mesa/drivers/dri/i965/brw_eu.c
@@ -61,7 +61,7 @@ brw_reg_type_letters(unsigned type)
       [BRW_REGISTER_TYPE_Q]  = "Q",
-   assert(type <= BRW_REGISTER_TYPE_UQ);
+   assert(type <= BRW_REGISTER_TYPE_Q);
    return names[type];

More information about the mesa-dev mailing list