[Mesa-dev] [Bug 84566] Unify the format conversion code

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=84566

--- Comment #18 from Iago Toral <itoral at igalia.com> ---
(In reply to Jason Ekstrand from comment #17)
> (In reply to Iago Toral from comment #16)
> > We also need new mesa_format enums and pack/unpack functions for byte
> > swapped variants of non-array types.
> 
> Why?  Is this for the byte_swapped flag on GL upload/downloads?  If that's
> the only reason, then I'd rather not bother adding mesa types.  We can
> easily do a byte swap with _mesa_swizzle_and_convert.  While it's a little
> bit of a performance hit, people shouldn't be using that attribute anyway.

I think that won't help in this case. We can only use _mesa_swizzle_and_convert
for array types, but as I say, this involves non-array types like
GL_UNSIGNED_INT_10_10_10_2. The master converter will not use
_mesa_swizzle_and_convert with these, it goes through things like
_mesa_unpack_rgba_row and _mesa_pack_float_rgba_row for example (which rely on
auto-generated pack/unpack functions). Do you think we should try expand these
to consider byte-swapping?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141015/77f68312/attachment.html>