[Mesa-dev] [Bug 84566] Unify the format conversion code

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=84566

--- Comment #30 from Jason Ekstrand <jason at jlekstrand.net> ---
(In reply to Iago Toral from comment #29)
> (In reply to Jason Ekstrand from comment #26)
> > (In reply to Iago Toral from comment #24)
> > > Jason, what do you think we should do for GL_COLOR_INDEX + GL_BITMAP?
> > > 
> > > Currently this is handled as a special case in the texstore.c ubyte path
> > > (store_ubyte_texture), specifically, the special case handles extracting
> > > indexed color data so that the incoming pixels can be represented as an RGBA
> > > image, then do the conversion from RGBA to dst normally.
> > > 
> > > We do not have a Mesa format for this combination.
> > > 
> > > I think we have two options:
> > > 1) I guess we could create a mesa_format, detect this case specifically in
> > > the master function and handle it there.
> > > 2) The other option would be to let clients deal with it. That would involve
> > > letting them transform it to RGBA before they call the master function.
> > > 
> > > What do you think?
> > 
> > Option 2.  Mesa internally hasn't supported color index in a long time,
> > let's not add it back.
> 
> What do you mean by not supporting it internally? As I mention in my reply
> to Kenneth I see multiple references to GL_COLOR_INDEX in Mesa, there is a
> specific path to deal with it in texstore and there are even piglit tests
> for this that pass in master...

Yes, we still support uploading textures as GL_COLOR_INDEX because we have to. 
However, we have not supported using indexed formats for render targets or
actual internal texture formats for some time.  In fact, I recently removed the
metadata about indexed formats from format_info.c.

> Just to be clear, when I said "clients" in option 2) I meant clients of the
> master function inside Mesa (so things like texstore.c). My idea was that
> things like texstore would handle GL_COLOR_INDEX and take care of converting
> it to RGBA on their own before calling the master function, but if you say
> that GL_COLOR_INDEX is not really supported any more, maybe we should just
> ignore it completely and do nothing about it in texstore and friends?

Yes, I got that.  As I said above, we still need to handle it in texture upload
because it's forever part of the GL spec.  However, we would rather keep it out
of core as much as possible.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141017/39eac59f/attachment-0001.html>