[Mesa-dev] [PATCH] glsl: Delete unused gl_uniform_driver_format enum values.
kenneth at whitecape.org
Tue Oct 21 18:56:44 PDT 2014
On Tuesday, October 21, 2014 08:05:43 AM Ian Romanick wrote:
> I have this exact patch setting in me queue to send out.
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> I had initially thought about going the other way, and using the enums
> instead of UniformBooleanTrue. I think the UniformBooleanTrue method
> slightly more efficient since there is only one place where value
> conversions occur.
Right. It seems like the remaining enums are a bit redundant as well,
given that we have ctx->Const.NativeIntegers, but ir_to_mesa uses it, so it
isn't technically dead yet. It seemed odd to me that st_glsl_to_tgsi
doesn't use uniform_int_float at all.
If anyone is bored and wants to tidy more code... :)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: This is a digitally signed message part.
More information about the mesa-dev