[Mesa-dev] [PATCH 3/4] u_blitter: use ctx->bind_fs_state(), not pipe->bind_fs_state()

[Brian Paul]

On 10/22/2014 04:31 PM, Marek Olšák wrote:
> For patches 1-3:
>
> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>
> Patch 4 seems to be missing on the mailing list.

Yeah, I don't know what happened to it.  But 4/4 only adds a comment on 
util_blitter_cache_all_shaders() so not a big deal.

-Brian


>
> Marek
>
> On Wed, Oct 22, 2014 at 11:16 PM, Brian Paul <brianp at vmware.com> wrote:
>> Consistently use the function pointer we saved earlier.
>> ---
>>   src/gallium/auxiliary/util/u_blitter.c |    6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c
>> index 830d82f..ea9094e 100644
>> --- a/src/gallium/auxiliary/util/u_blitter.c
>> +++ b/src/gallium/auxiliary/util/u_blitter.c
>> @@ -361,7 +361,7 @@ static void bind_fs_empty(struct blitter_context_priv *ctx)
>>         ctx->fs_empty = util_make_empty_fragment_shader(pipe);
>>      }
>>
>> -   pipe->bind_fs_state(pipe, ctx->fs_empty);
>> +   ctx->bind_fs_state(pipe, ctx->fs_empty);
>>   }
>>
>>   static void bind_fs_write_one_cbuf(struct blitter_context_priv *ctx)
>> @@ -375,7 +375,7 @@ static void bind_fs_write_one_cbuf(struct blitter_context_priv *ctx)
>>                                                  TGSI_INTERPOLATE_CONSTANT, FALSE);
>>      }
>>
>> -   pipe->bind_fs_state(pipe, ctx->fs_write_one_cbuf);
>> +   ctx->bind_fs_state(pipe, ctx->fs_write_one_cbuf);
>>   }
>>
>>   static void bind_fs_write_all_cbufs(struct blitter_context_priv *ctx)
>> @@ -389,7 +389,7 @@ static void bind_fs_write_all_cbufs(struct blitter_context_priv *ctx)
>>                                                  TGSI_INTERPOLATE_CONSTANT, TRUE);
>>      }
>>
>> -   pipe->bind_fs_state(pipe, ctx->fs_write_all_cbufs);
>> +   ctx->bind_fs_state(pipe, ctx->fs_write_all_cbufs);
>>   }
>>
>>   void util_blitter_destroy(struct blitter_context *blitter)
>> --
>> 1.7.10.4
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=mDky4a9NWRTJROpiD%2BUxwvg6%2FZ2gsPQE2rAlghPH%2BkY%3D%0A&s=cccfe3cee5bca8a44cc9ff1e4c88bd3d55a433b57ab55087f88c701285d95537