[Mesa-dev] [PATCH v2] r600g: Implement GL_ARB_sample_shading

[Alexandre Demers]

Thanks Marek, you were right.

So, on cayman, after comparing results from both runs, it seems there is 
only one regression which is gs-atan-vec2 under glsl-1.50:
piglit/bin/shader_runner 
/home/ademers/projects/display/piglit/generated_tests/spec/glsl-1.50/execution/built-in-functions/gs-atan-vec2.shader_test 
-auto

The returned value is the following:
Probe color at (5,0)
   Expected: 0.000000 1.000000 0.000000 1.000000
   Observed: 1.000000 0.000000 0.000000 1.000000

Overall, here are the result summary comparing "before the patch" and 
"after the patch":
all
17474/18716    17514/18755
spec
15903/17106    15943/17145
glsl-1.50
3059/3106    3060/3106
execution
1628/1672    1629/1672
built-in-functions
1485/1487    1486/1487
gs-atan-vec2
pass    fail

Add this to my results with Tesseract and it is definitively an improvement.

Alexandre Demers

On 05/09/14 11:19 AM, Marek Olšák wrote:
> You can skip glx tests using these piglit-run parameters: -x glx -x makeCurrent
>
> That should prevent X from crashing.
>
> Marek
>
> On Fri, Sep 5, 2014 at 7:07 AM, Alexandre Demers
> <alexandre.f.demers at gmail.com> wrote:
>> I've been testing your patch v2 on cayman.
>>
>> Here are my results. For now, my piglit runs are not conclusive because a
>> quick run fails even without your patch: almost at the end of the run, X
>> crashes.
>>
>> However, using Tesseract as you suggested gave good results. First, it fixes
>> a visual glitch appearing on object's edges. Also, being at the same
>> position and pointing at the same place resulted in a FPS rate greatly
>> improved (from 21 fps to 37 fps).
>>
>> So it seems good on cayman. I'll try to confirm it even further with a good
>> piglit run if I find a way to run it correctly first without the patch.
>>
>> --
>> Alexandre Demers
>>
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev