[Mesa-dev] [Bug 84145] UE4: Realistic Rendering Demo render blue

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=84145

--- Comment #10 from Ilia Mirkin <imirkin at alum.mit.edu> ---
(In reply to comment #6)
> Ilia, any ideas?

Oh neat. I was seeing that render blue as well, but was assuming it was due to
some spill errors that I had only semi-fixed.

The interesting thing to note is that the commit in question doesn't actually
enable ARB_texture_view on any driver, just sets the stage for it.

My guess is that it's due to the st_format.c hunk, but I can't imagine why. Oh
hrm. Perhaps this hunk, I can't remember what that did, but it seems
potentially dodgy:

@@ -970,7 +971,10 @@ st_GetTexImage(struct gl_context * ctx,
     * - Luminance alpha must be returned as (L,0,0,A).
     * - Intensity must be returned as (I,0,0,1)
     */
-   src_format = util_format_linear(src->format);
+   if (stObj->surface_based)
+      src_format = util_format_linear(stObj->surface_format);
+   else
+      src_format = util_format_linear(src->format);
    src_format = util_format_luminance_to_red(src_format);
    src_format = util_format_intensity_to_red(src_format);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140922/9db2626f/attachment.html>