[Mesa-dev] [PATCH 4/4] glsl: Fix no return value for non-void function

[Tomasz Figa]

On 27.09.2014 16:40, Emil Velikov wrote:
> On 27/09/14 15:20, Tomasz Figa wrote:
>> Even though scope outside the switch statement is unreachable, the
>> compiler generates a warning, which is treated as error by Android
>> toolchain. Fix the issue by adding dummy return statement.
>>
> I fear that other may have a preference to fix the compiler/build
> toolchain rather than adding the return here.

I thought the same, but decided just to post what I have right now,
until I'll be able to further investigate. Feel free to ignore this
patch for now if it isn't suitable.

> Did you manage to find any form of detection for the builtins ?

I didn't have an opportunity to look into this yet. I will keep you
updated with my findings, if any.

> Otherwise one might just set the define HAVE___BUILTIN_UNREACHABLE.

This might indeed be what's needed here. I'll check this.

Best regards,
Tomasz