[Mesa-dev] [PATCH 0/4] Fix Mesa Android build issues

Emil Velikov emil.l.velikov at gmail.com
Sat Sep 27 07:53:14 PDT 2014


Hi Tomasz,
On 27/09/14 15:19, Tomasz Figa wrote:
> This series contains patches fixing build issues spotted while trying to
> compile current Mesa master in Android build system. The exact Android
> version used was AndroidArmv6 [1] which is directly based on CyanogemMod 11
> with additional patches for ARMv6. In terms of build system, it does not
> differ from clean AOSP 4.4.4-r2, except some target-specific tweaks, which
> should not affect general build mechanics.
> 
> I have not tested builds with Classic drivers enabled, as my test
> environment is quite specific (ARMv6) with minimal set of dependencies
> (libdrm and libdrm-freedreno).
> 
Huge thanks for tackling this :)

Haven't tested your patches but they look good to me. Patches 1-3 are
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

I'll push 1-3 mid/late this week, so that anyone interested to give them
a test.

Despite my comment on patch 4, but I have no objections about it. Would
be nice to see if other people are in the same boat as me.

Thanks again
Emil

> [1] http://androidarmv6.github.io/
> 
> Tomasz Figa (4):
>   util: Include in Android builds
>   st/mesa: Generate format_info.c in Android builds
>   st/mesa: Fix paths used in Android builds
>   glsl: Fix no return value for non-void function
> 
>  Android.mk                             |   1 +
>  src/egl/main/Android.mk                |   1 +
>  src/gallium/auxiliary/Android.mk       |   4 +-
>  src/glsl/Android.mk                    |   4 +-
>  src/glsl/opt_vectorize.cpp             |   1 +
>  src/mesa/Android.gen.mk                |   9 +++
>  src/mesa/Android.libmesa_dricore.mk    |   3 +
>  src/mesa/Android.libmesa_glsl_utils.mk |   4 +-
>  src/mesa/Android.libmesa_st_mesa.mk    |   3 +
>  src/mesa/program/Android.mk            |   3 +
>  src/util/Android.mk                    | 102 +++++++++++++++++++++++++++++++++
>  11 files changed, 131 insertions(+), 4 deletions(-)
>  create mode 100644 src/util/Android.mk
> 



More information about the mesa-dev mailing list