[Mesa-dev] [PATCH 1/4] i965/fp: Set coord_components correctly for cube textures.

Kenneth Graunke kenneth at whitecape.org
Sat Apr 4 01:23:25 PDT 2015


I've no idea why this was 4.  It certainly seems wrong.

Prevents assertion failures in fp-incomplete-tex with some upcoming
patches of mine.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This series is available on the 'gen4-simd16' branch of my tree.

diff --git a/src/mesa/drivers/dri/i965/brw_fs_fp.cpp b/src/mesa/drivers/dri/i965/brw_fs_fp.cpp
index c4064da..21d677a 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_fp.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_fp.cpp
@@ -448,7 +448,7 @@ fs_visitor::emit_fragment_program_code()
             break;
 
          case TEXTURE_CUBE_INDEX: {
-            coord_components = 4;
+            coord_components = 3;
 
             fs_reg temp = vgrf(glsl_type::float_type);
             fs_reg cubecoord = vgrf(glsl_type::vec3_type);
-- 
2.1.2



More information about the mesa-dev mailing list