[Mesa-dev] [PATCH 3/3] i965: Make sure GS output streams 1-3 aren't rasterized on Haswell+.

[Kenneth Graunke]

On Monday, April 06, 2015 10:01:16 AM Matt Turner wrote:
> On Sat, Apr 4, 2015 at 3:46 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > Presumably no one has noticed this breakage because
> > ARB_transform_feedback3 isn't exposed on Haswell due to the ongoing
> > command streamer shenanigans, and ARB_gpu_shader5 isn't exposed on
> > Broadwell because we keep forgetting about it.
> >
> > Fixes 3 Piglit tests:
> > - spec/arb_gpu_shader5/emitstreamvertex_nodraw
> 
> Iago sent a patch about a month ago that fixes this. It'd be nice to
> take a look and see how it interacts with this:
> 
> "[PATCH] i965: Do not render primitives in non-zero streams then TF is disabled"

Ah, right!  I completely forgot about that patch.

Iago's approach is much better - I've added my Reviewed-by and pushed it.
I made a small tweak to drop the is_haswell check, since the workaround
is also necessary on Broadwell, and seems reasonable to apply on all
platforms.

Thanks Iago!  Thanks Matt!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150406/af070742/attachment.sig>