[Mesa-dev] [PATCH v2 1/2] primconvert: select pv convention only from flatshade_first

Ilia Mirkin imirkin at alum.mit.edu
Tue Apr 7 09:19:55 PDT 2015


BTW, I should have mentioned -- this affects the way that quads are
split up into tri's, which is most likely the source of any
differences from my later change which makes quads respect pv order.

On Tue, Apr 7, 2015 at 12:12 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> This should match to how drivers program hardware. It shouldn't matter
> when flatshading isn't in effect, but somehow it seems to.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/gallium/auxiliary/indices/u_primconvert.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/gallium/auxiliary/indices/u_primconvert.c b/src/gallium/auxiliary/indices/u_primconvert.c
> index 00e65aa..70d3e85 100644
> --- a/src/gallium/auxiliary/indices/u_primconvert.c
> +++ b/src/gallium/auxiliary/indices/u_primconvert.c
> @@ -104,8 +104,7 @@ util_primconvert_save_rasterizer_state(struct primconvert_context *pc,
>      * we would actually need to save/restore rasterizer state.  As
>      * it is, we just need to make note of the pv.
>      */
> -   pc->api_pv = (rast->flatshade
> -                 && !rast->flatshade_first) ? PV_LAST : PV_FIRST;
> +   pc->api_pv = rast->flatshade_first ? PV_FIRST : PV_LAST;
>  }
>
>  void
> --
> 2.0.5
>


More information about the mesa-dev mailing list