[Mesa-dev] [PATCH 0/3] Hash-table and hash-set, V4

Jason Ekstrand jason at jlekstrand.net
Mon Apr 13 15:10:16 PDT 2015


On Sat, Apr 11, 2015 at 4:25 PM, Thomas Helland
<thomashelland90 at gmail.com> wrote:
> The performance numbers (shader-db runtime) are:
>
> Difference at 95.0% confidence
>       -14.7608 +/- 3.36786
>      -9.05064% +/- 2.06501%
> (Original runtime was 160 seconds)

Good Work!

I had one comment on the hash set patch.  With that fixed, the series is

Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

Probably want to give Eric a a couple of days to look at it too.

> While the profile data looked promising for increasing the
> table size we start with, decreasing load factor, and integer hashing,
> there seems to be no benefit to shader-db runtime.
> Therefore I have dropped these from the series.
>
> Thomas Helland (3):
>   util/tests: Expand collision test for hash table
>   util: Change hash_table to use quadratic probing
>   util: Change util/set to use quadratic probing
>
>  src/util/hash_table.c                 | 102 +++++++++--------------------
>  src/util/hash_table.h                 |   3 +-
>  src/util/set.c                        | 118 ++++++++++++----------------------
>  src/util/set.h                        |   3 +-
>  src/util/tests/hash_table/collision.c |  14 ++++
>  5 files changed, 89 insertions(+), 151 deletions(-)
>
> --
> 2.3.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list