[Mesa-dev] [PATCH] glsl: extend GLSLSkipStrictMaxUniformLimitCheck to uniform block size

Marcin Ĺšlusarz marcin.slusarz at gmail.com
Mon Apr 13 16:08:34 PDT 2015


On Tue, Apr 14, 2015 at 12:05:25AM +0200, Roland Scheidegger wrote:
> FWIW fsexceed crashes badly with llvmpipe (this is because we copy the
> constants into scene data, and the block size there is 64kB). I've
> actually wondered if it's the state tracker's job or that of the driver
> to ensure nothing bad happens. It is however happening due to the actual
> buffer being larger, the declaration in the shader is irrelevant for
> this crash.

For me, these tests pass on llvmpipe even without this patch, but I guess
it's only by accident - if I patch fsexceed to test much bigger buffer,
it fails with fireworks (corruption in glibc). However with this patch
llvmpipe passes - as expected - by failing to link.

Marcin


More information about the mesa-dev mailing list