[Mesa-dev] [PATCH 1/3] nir: Silence unused parameter warnings

Jordan Justen jordan.l.justen at intel.com
Tue Apr 14 09:05:57 PDT 2015


Yikes. Good catch on 3/3. :)

Series Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

On 2015-04-14 08:43:39, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> nir/nir.h: In function 'nir_validate_shader':
> nir/nir.h:1567:56: warning: unused parameter 'shader' [-Wunused-parameter]
>  static inline void nir_validate_shader(nir_shader *shader) { }
>                                                         ^
> nir/nir_opt_cse.c: In function 'src_is_ssa':
> nir/nir_opt_cse.c:165:32: warning: unused parameter 'data' [-Wunused-parameter]
>  src_is_ssa(nir_src *src, void *data)
>                                 ^
> nir/nir_opt_cse.c: In function 'dest_is_ssa':
> nir/nir_opt_cse.c:171:35: warning: unused parameter 'data' [-Wunused-parameter]
>  dest_is_ssa(nir_dest *dest, void *data)
>                                    ^
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/glsl/nir/nir.h         | 2 +-
>  src/glsl/nir/nir_opt_cse.c | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
> index 2d1d870..74772c7 100644
> --- a/src/glsl/nir/nir.h
> +++ b/src/glsl/nir/nir.h
> @@ -1570,7 +1570,7 @@ void nir_print_instr(const nir_instr *instr, FILE *fp);
>  #ifdef DEBUG
>  void nir_validate_shader(nir_shader *shader);
>  #else
> -static inline void nir_validate_shader(nir_shader *shader) { }
> +static inline void nir_validate_shader(nir_shader *shader) { (void) shader; }
>  #endif /* DEBUG */
>  
>  void nir_calc_dominance_impl(nir_function_impl *impl);
> diff --git a/src/glsl/nir/nir_opt_cse.c b/src/glsl/nir/nir_opt_cse.c
> index 9b38320..03039cf 100644
> --- a/src/glsl/nir/nir_opt_cse.c
> +++ b/src/glsl/nir/nir_opt_cse.c
> @@ -154,12 +154,14 @@ nir_instrs_equal(nir_instr *instr1, nir_instr *instr2)
>  static bool
>  src_is_ssa(nir_src *src, void *data)
>  {
> +   (void) data;
>     return src->is_ssa;
>  }
>  
>  static bool
>  dest_is_ssa(nir_dest *dest, void *data)
>  {
> +   (void) data;
>     return dest->is_ssa;
>  }
>  
> -- 
> 2.1.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list