[Mesa-dev] [PATCH] glx: Create proper server dependency for GLX_EXT_create_context_es2_profile

Chad Versace chad.versace at intel.com
Wed Apr 15 13:44:34 PDT 2015


On Tue 14 Apr 2015, Ian Romanick wrote:
>From: Ian Romanick <ian.d.romanick at intel.com>
>
>Previously GLX_EXT_create_context_es2_profile was marked as "direct
>only" so that it would not depend on server support.  Since the
>extension required functions that are part of
>GLX_ARB_create_context_profile, support for the EXT was disabled if the
>ARB was not supported.
>
>This was complete rubbish.  If the server supported the ARB but not the
>EXT, sending a request with GLX_CONTEXT_ES2_PROFILE_BIT_EXT would result
>in GLXBadProfileARB.
>
>Instead of the misguided hack, make GLX_EXT_create_context_es2_profile
>properly depend on server support by not marking it as "direct only."
>
>Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>Cc: José Fonseca <jfonseca at vmware.com>
>Cc: Chad Versace <chad.versace at intel.com>
>Cc: Emil Velikov <emil.l.velikov at gmail.com>
>---
> src/glx/glxextensions.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)

There's a lot of subtlety here, but it looks correct as far as I can
tell.

Reviewed-by: Chad Versace <chad.versace at intel.com>



More information about the mesa-dev mailing list