[Mesa-dev] [PATCH] main: remove __FUNCTION__ defined because it is obsolete

Predut, Marius marius.predut at intel.com
Thu Apr 16 06:04:03 PDT 2015


> -----Original Message-----
> From: Emil Velikov [mailto:emil.l.velikov at gmail.com]
> Sent: Thursday, April 16, 2015 1:53 PM
> To: Predut, Marius
> Cc: ML mesa-dev
> Subject: Re: [Mesa-dev] [PATCH] main: remove __FUNCTION__ defined because it
> is obsolete
> 
> Hi Marius,
> 
> On 16 April 2015 at 11:36, Marius Predut <marius.predut at intel.com> wrote:
> > Consistently just use C99's __func__ everywhere.
> > No functional changes.
> > Apply this patch after "radeon: replace __FUNCTION__ with __func__" patch.
> >
> Tip: If you send the patches as series (git format-patch -2) this will
> implicitly provide/preserve the dependency chain.

Ok thanks, in this case if u plan commit it , may be is better to adjust the comment by removing last line.

> 
> Both patches are trivial enough, plus other places of mesa have their own
> redefinition of the symbol. I'll do a quick build test and push them in the
> next few hours. Unless there are any objections of course
> :-)
> 
> > Signed-off-by: Marius Predut <marius.predut at intel.com>
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
> 
> Thanks
> Emil


More information about the mesa-dev mailing list