[Mesa-dev] [PATCH 2/3] glsl: add fallthrough comment on switch

Tapani tapani.palli at intel.com
Tue Apr 21 09:29:46 PDT 2015


On 04/21/2015 06:19 PM, Matt Turner wrote:
> On Mon, Apr 20, 2015 at 10:37 PM, Matt Turner <mattst88 at gmail.com> wrote:
>> On Mon, Apr 20, 2015 at 10:27 PM, Tapani Pälli <tapani.palli at intel.com> wrote:
>>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>>> ---
>>>   src/glsl/linker.cpp | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
>>> index b6baa5d..08b4137 100644
>>> --- a/src/glsl/linker.cpp
>>> +++ b/src/glsl/linker.cpp
>>> @@ -2571,6 +2571,7 @@ add_interface_variables(struct gl_shader_program *shProg,
>>>                var->data.location != SYSTEM_VALUE_VERTEX_ID_ZERO_BASE &&
>>>                var->data.location != SYSTEM_VALUE_INSTANCE_ID)
>>>            continue;
>> The continue should be indented.
>>
>>> +         /* FALLTHROUGH */
> In what was committed, you indented both the continue and the /* FALLTHROUGH */

Yep that seems to be the case, sorry about that.

// Tapani



More information about the mesa-dev mailing list