[Mesa-dev] [PATCH 04/23] i965: Make the brw_inst helpers take a device_info instead of a context

Matt Turner mattst88 at gmail.com
Tue Apr 21 11:26:11 PDT 2015


On Tue, Apr 21, 2015 at 9:59 AM, Matt Turner <mattst88 at gmail.com> wrote:
> I don't know how reasonable this suggestion is until I read further in
> the series, but I'd rather pass 'p' to the brw_inst functions instead
> of p->devinfo.
>
> That would match better with brw_$INST functions and would shorten the
> argument name instead of more than tripling it.

Okay, yeah. Everything gets churned between here and the end of the series.

Ultimately the change seems to be s/brw/devinfo/... I think that's
probably fine.


More information about the mesa-dev mailing list