[Mesa-dev] i965: Batch emission refactoring

Pohjolainen, Topi topi.pohjolainen at intel.com
Thu Apr 23 12:03:16 PDT 2015


On Thu, Apr 23, 2015 at 11:56:31AM -0700, Matt Turner wrote:
> I've looked through all 18 patches, and they look fine to me -- but
> I'm not sure how much that's worth.
> 
> I noted a bunch of whitespace mistakes (Is there a way to configure
> git commit to warn you about things like this?) but not much else. I
> don't know if that's because the series is perfect or if I don't know
> enough to actually do a meaningful review.

Thanks for noticing the whitespace errors, I'll check my tools to warn
me about them instead of bothering other people in the future.

> 
> I feel comfortable giving an
> 
> Acked-by: Matt Turner <mattst88 at gmail.com>
> 
> for the first 17 patches. I wasn't sure about removing 'static' in 18.


More information about the mesa-dev mailing list