[Mesa-dev] [PATCH] i965: Add an INTEL_DEBUG=spill option to test spilling

Ilia Mirkin imirkin at alum.mit.edu
Thu Apr 23 12:26:36 PDT 2015


On Thu, Apr 23, 2015 at 3:20 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
>
> On Apr 23, 2015 12:19 PM, "Neil Roberts" <neil at linux.intel.com> wrote:
>>
>> Ilia Mirkin <imirkin at alum.mit.edu> writes:
>>
>> > That seems awkward... did you mean 1U? FWIW mesa's not at all careful
>> > about that...
>>
>> Or maybe even UINT64_C(1). 1l would still be 32-bit on 32-bit
>> architectures. I guess this is more of a problem for subsequent flags
>> that go over 32-bit.

Technically 1 << 31 is undefined in C. Practically it works just fine.

>
> How about 1ull?

That works too. FWIW I've always done ULL, not ull -- not sure what
the mesa convention is. Oftentimes there are BIT() and BIT64() macros
that abstract all this out, but I couldn't find them on a quick scan.

  -ilia


More information about the mesa-dev mailing list