[Mesa-dev] [PATCH 5/7] i965: use _mesa_geometry_width/height/layers/samples for programming geometry of framebuffer to GEN

[Rogovin, Kevin]

> My point specifically was that you are also updating atoms that _are not_ re-used. 
> And as those changes are not really needed, I wouldn't take the risk of changing 
> something in vain. I would introduce them only when you have patches to really enable older generations.

My take is the following:

 1. Tracking (and guaranteeing) that those function left unchanged as is are 
exactly just those for before Gen7 is a pain. Much easier, and more reliable 
to hit them all instead. A significant number of functions in i965 are not emit 
functions of any atom but emit functions of atoms map to them. Again, more 
reliable and -safer- to change them all, then just the bare minimum. 

2. The change is benign. If _HasAttachments is true, then the function substitution 
gives the same value. For Gens not supporting the extension there is no effect.

3. Lastly, as stated: for later it leaves the option to enable it for Gen6 and below,
it is just trivial change, but it needs testing on hardware.

When I writing this work, I originally had it for all Gens, but changed to support
only Gen7and higher because that is all on which I can test it. 

-Kevin