[Mesa-dev] [PATCH v2 18/20] i965: Remove comment about chv device numbers relating to hsw gt1

[Kenneth Graunke]

On Friday, April 24, 2015 04:33:10 PM Jordan Justen wrote:
> Remove comment "These were copied from Haswell GT1, above.". Many of
> these numbers have been modified by this point, so the HSW GT1
> reference no longer seems helpful.
> 
> The comment "Thread counts and URB limits are placeholders, and may
> not be accurate." is retained for now.
> 
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_device_info.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c b/src/mesa/drivers/dri/i965/brw_device_info.c
> index 7999ba9..8938384 100644
> --- a/src/mesa/drivers/dri/i965/brw_device_info.c
> +++ b/src/mesa/drivers/dri/i965/brw_device_info.c
> @@ -278,9 +278,7 @@ static const struct brw_device_info brw_device_info_bdw_gt3 = {
>     }
>  };
>  
> -/* Thread counts and URB limits are placeholders, and may not be accurate.
> - * These were copied from Haswell GT1, above.
> - */
> +/* Thread counts and URB limits are placeholders, and may not be accurate. */
>  static const struct brw_device_info brw_device_info_chv = {
>     GEN8_FEATURES, .is_cherryview = 1, .gt = 1,
>     .has_llc = false,
> 

I actually think they're accurate at this point, so you can just drop
the comment entirely.  A patch to do that would get my R-b.

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150424/8707431b/attachment.sig>