[Mesa-dev] [PATCH 01/18] winsys/radeon: move radeon_winsys.h up one directory

[Marek Olšák]

Can you elaborate on what amdgpu/sw would be good for? Frankly I don't
see a point, therefore we don't need the "drm" subdirectory.

Marek

On Tue, Apr 21, 2015 at 4:40 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 20/04/15 22:23, Marek Olšák wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> ---
>>  .../auxiliary/target-helpers/inline_drm_helper.h   |   6 +-
>>  src/gallium/drivers/r300/r300_chipset.c            |   2 +-
>>  src/gallium/drivers/r300/r300_context.h            |   1 -
>>  src/gallium/drivers/r300/r300_screen.h             |   2 +-
>>  src/gallium/drivers/radeon/r600_pipe_common.h      |   2 +-
>>  src/gallium/drivers/radeon/radeon_uvd.c            |   1 -
>>  src/gallium/drivers/radeon/radeon_uvd.h            |   2 +-
>>  src/gallium/drivers/radeon/radeon_vce.c            |   1 -
>>  src/gallium/drivers/radeon/radeon_vce_40_2_2.c     |   1 -
>>  src/gallium/drivers/radeon/radeon_video.c          |   1 -
>>  src/gallium/drivers/radeon/radeon_video.h          |   2 +-
>>  src/gallium/drivers/radeonsi/si_pm4.h              |   2 +-
>>  src/gallium/targets/pipe-loader/pipe_r300.c        |   2 +-
>>  src/gallium/targets/pipe-loader/pipe_r600.c        |   2 +-
>>  src/gallium/targets/pipe-loader/pipe_radeonsi.c    |   2 +-
>>  src/gallium/winsys/radeon/drm/Makefile.sources     |   2 +-
>>  src/gallium/winsys/radeon/drm/radeon_drm_winsys.h  |   2 +-
>>  src/gallium/winsys/radeon/drm/radeon_winsys.h      | 604 ---------------------
>>  src/gallium/winsys/radeon/radeon_winsys.h          | 604 +++++++++++++++++++++
>>  19 files changed, 618 insertions(+), 623 deletions(-)
>>  delete mode 100644 src/gallium/winsys/radeon/drm/radeon_winsys.h
>>  create mode 100644 src/gallium/winsys/radeon/radeon_winsys.h
>>
> Another solution would be to move it in gallium/drivers/radeon. This one
> might be better (and more consistent with every other driver) as the
> file defines the interface that the driver(s) require, while there can
> be many different providers for it - radeon/drm, amdgpu/drm or even
> amdgpu/sw :-)
>
> You might need to change two/three lines in the makefiles though :-\
>
> -Emil
>