[Mesa-dev] [PATCH] gallium/radeon: always use the llvm. prefix in intrinsic names

Michel Dänzer michel at daenzer.net
Mon Aug 3 01:29:47 PDT 2015


On 01.08.2015 00:35, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>

[...]

> @@ -1176,8 +1176,18 @@ static void emit_frac(
>  		struct lp_build_emit_data * emit_data)
>  {
>  	LLVMBuilderRef builder = bld_base->base.gallivm->builder;
> -
> -	LLVMValueRef floor = lp_build_intrinsic(builder, "floor", emit_data->dst_type,
> +        char *intr;
> +
> +        if (emit_data->info->opcode == TGSI_OPCODE_FRC)
> +            intr = "llvm.floor.f32";
> +        else if (emit_data->info->opcode == TGSI_OPCODE_DFRAC)
> +            intr = "llvm.floor.f64";
> +        else {
> +            assert(0);
> +            return;
> +        }

The code you're adding here uses spaces for indentation, whereas the
surrounding code seems to use tabs. With that fixed,

Acked-by: Michel Dänzer <michel.daenzer at amd.com>

but Tom should take a look as well.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the mesa-dev mailing list