[Mesa-dev] [PATCH] gallium/radeon: always use the llvm. prefix in intrinsic names

[Tom Stellard]

On Mon, Aug 03, 2015 at 05:29:47PM +0900, Michel Dänzer wrote:
> On 01.08.2015 00:35, Marek Olšák wrote:
> > From: Marek Olšák <marek.olsak at amd.com>
> 
> [...]
> 
> > @@ -1176,8 +1176,18 @@ static void emit_frac(
> >  		struct lp_build_emit_data * emit_data)
> >  {
> >  	LLVMBuilderRef builder = bld_base->base.gallivm->builder;
> > -
> > -	LLVMValueRef floor = lp_build_intrinsic(builder, "floor", emit_data->dst_type,
> > +        char *intr;
> > +
> > +        if (emit_data->info->opcode == TGSI_OPCODE_FRC)
> > +            intr = "llvm.floor.f32";
> > +        else if (emit_data->info->opcode == TGSI_OPCODE_DFRAC)
> > +            intr = "llvm.floor.f64";
> > +        else {
> > +            assert(0);
> > +            return;
> > +        }
> 
> The code you're adding here uses spaces for indentation, whereas the
> surrounding code seems to use tabs. With that fixed,
> 
> Acked-by: Michel Dänzer <michel.daenzer at amd.com>
> 

Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

> but Tom should take a look as well.
> 
> 
> -- 
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev