[Mesa-dev] [PATCH 17/25] glsl: Remove duplicate definition of gl_MaxTess*ImageUniforms built-in constants.

Tapani Pälli tapani.palli at intel.com
Tue Aug 18 02:57:35 PDT 2015


patches 17,18,19,20:
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

On 08/17/2015 07:45 PM, Francisco Jerez wrote:
> These seem to have been re-added at some point during the
> ARB_tessellation_shader implementation work.  AFAICT the second
> (correct) definition of each constant would have had no effect because
> the symbols were already defined.
> ---
>   src/glsl/builtin_variables.cpp | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp
> index c6fdccf..4966ba3 100644
> --- a/src/glsl/builtin_variables.cpp
> +++ b/src/glsl/builtin_variables.cpp
> @@ -754,8 +754,6 @@ builtin_variable_generator::generate_constants()
>                   state->Const.MaxImageSamples);
>         add_const("gl_MaxVertexImageUniforms",
>                   state->Const.MaxVertexImageUniforms);
> -      add_const("gl_MaxTessControlImageUniforms", 0);
> -      add_const("gl_MaxTessEvaluationImageUniforms", 0);
>         add_const("gl_MaxGeometryImageUniforms",
>                   state->Const.MaxGeometryImageUniforms);
>         add_const("gl_MaxFragmentImageUniforms",
>


More information about the mesa-dev mailing list