[Mesa-dev] [PATCH v3] mesa: don't enable online compression for ASTC formats
nanleychery at gmail.com
Wed Aug 19 15:19:59 PDT 2015
Agreed. I've updated the patch. Thanks.
On Mon, Aug 17, 2015 at 11:39 AM, Chad Versace <chad.versace at intel.com>
> On Tue 11 Aug 2015, Nanley Chery wrote:
> > From: Nanley Chery <nanley.g.chery at intel.com>
> > In agreement with the ASTC spec, this makes calls to TexImage*D
> > Implied by the spec, Generate[Texture]Mipmap and [Copy]TexSubImage*D
> > must be unsuccessful as well.
> > v2. actually force attempts to compress online to fail.
> > v3. indentation (Matt).
> > Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> I think your patch is missing a needed hunk. The patch updates 3 of the
> 5 callers of compressedteximage_only_format to use
> _mesa_format_no_online_compression isntead. Here are the 5 callers:
> ✓ texture_error_check (covers glTexImage*D)
> ✓ texsubimage_error_check
> ✓ copytexsubimage_error_check
> ✗ copytexture_error_check (covers glCopyTexImage*D)
> ✗ compressed_subtexture_error_check (covers glCompressedTexSubImage*D)
> I think you need to also update copytexture_error_check, because
> glCopyTexImage*D is unable copy pixels to an ASTC texture.
> Other than that, this patch looks good to me. Fix that and it's
> Reviewed-by: Chad Versace <chad.versace at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the mesa-dev