[Mesa-dev] [PATCH] st/nine: Disable NV path, it's broken right now.

[Axel Davy]

This patch is the result of several discussions on our irc channels.

I amended the commit message to:

st/nine: Always use user constant buffers

We had several reports of users hitting bugs
with the other path to upload constants,
and switching to the user constant buffer
path solves the bugs.

User constant buffers are expected to be slower
for Nvidia cards, so ideally this patch should be
reverted when the path is fixed.


I add this patch to the list of patches I will merge today.

Axel DAvy

On 21/08/2015 13:05, Krzysztof A. Sobiecki wrote :
> st/nine: Disable NV path, it's broken right now.
>
> Signed-off-by: Krzysztof Sobiecki <sobkas at gmail.com>
> ---
>   src/gallium/state_trackers/nine/device9.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c
> index 673b7a4..555f11d 100644
> --- a/src/gallium/state_trackers/nine/device9.c
> +++ b/src/gallium/state_trackers/nine/device9.c
> @@ -310,10 +310,12 @@ NineDevice9_ctor( struct NineDevice9 *This,
>   
>           if (strstr(pScreen->get_name(pScreen), "AMD") ||
>               strstr(pScreen->get_name(pScreen), "ATI")) {
> -            This->prefer_user_constbuf = TRUE;
>               This->driver_bugs.buggy_barycentrics = TRUE;
>           }
>   
> +        /* Disable NV path for now, needs some fixes */
> +        This->prefer_user_constbuf = TRUE;
> +
>           tmpl.target = PIPE_BUFFER;
>           tmpl.format = PIPE_FORMAT_R8_UNORM;
>           tmpl.height0 = 1;

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150821/d75ed750/attachment.html>