[Mesa-dev] [PATCH v4 (part2) 53/59] glapi: add ARB_shader_storage_block_buffer_object

Emil Velikov emil.l.velikov at gmail.com
Mon Aug 24 07:10:03 PDT 2015


Hi Samuel, Iago,

On 05/08/15 09:30, Iago Toral Quiroga wrote:
> From: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
> 
> v2:
> - Add ShaderStorageBlockBinding to static_data.py
> 
Why (see comment below) ?


v4:
 - Ship ARB_shader_storage_buffer_object.xml in the tarball.

Seems like other patches are also missing v4 revision history :|


> --- a/src/mapi/glapi/gen/static_data.py
> +++ b/src/mapi/glapi/gen/static_data.py
> @@ -1305,6 +1305,7 @@ functions = [
>     "ShaderBinary",
>     "ShaderSource",
>     "ShaderSourceARB",
> +   "ShaderStorageBlockBinding",
This list is for functions exported by libGL.so, which imho should not
change (ever). If there is there a program that depends on this static
symbol (and the binary drivers expose it), it should be noted in the
commit message.

Thanks
Emil

P.S. Have mercy on us, don't resent the 50+ series again ;)



More information about the mesa-dev mailing list