[Mesa-dev] [PATCH v4 (part2) 53/59] glapi: add ARB_shader_storage_block_buffer_object
Samuel Iglesias Gonsálvez
siglesias at igalia.com
Mon Aug 24 22:42:38 PDT 2015
On 24/08/15 16:10, Emil Velikov wrote:
> Hi Samuel, Iago,
> On 05/08/15 09:30, Iago Toral Quiroga wrote:
>> From: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
>> - Add ShaderStorageBlockBinding to static_data.py
> Why (see comment below) ?
> - Ship ARB_shader_storage_buffer_object.xml in the tarball.
> Seems like other patches are also missing v4 revision history :|
We usually send a new version of the patch series when we have not
received more reviews for several days/weeks and we have enough number
of changes in different patches (because of reviews and/or major changes
in master that invalidate our code).
For that reason, some of our patches don't have new comments in the
>> --- a/src/mapi/glapi/gen/static_data.py
>> +++ b/src/mapi/glapi/gen/static_data.py
>> @@ -1305,6 +1305,7 @@ functions = [
>> + "ShaderStorageBlockBinding",
> This list is for functions exported by libGL.so, which imho should not
> change (ever). If there is there a program that depends on this static
> symbol (and the binary drivers expose it), it should be noted in the
> commit message.
This is a new function defined by ARB_shader_storage_buffer_object
I have a test program that uses that function. If I remove the
static_data.py definition, I hit this linker error:
<file>: undefined reference to `glShaderStorageBlockBinding'
So following what how other functions are defined, I added it to
static_data.py. Is there any better place to define this function?
> P.S. Have mercy on us, don't resent the 50+ series again ;)
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
More information about the mesa-dev