[Mesa-dev] [PATCH 8/9] softpipe: enable PIPE_CAP_COPY_IMAGE

Ilia Mirkin imirkin at alum.mit.edu
Thu Aug 27 17:01:47 PDT 2015


Are you sure you want to enable it in spite of the fact that it
doesn't handle swizzling (which you've slightly papered over by
switching some of the format orders around, but as I pointed out not
completely)?

On Thu, Aug 27, 2015 at 7:48 PM, Brian Paul <brianp at vmware.com> wrote:
> This enables GL_ARB_copy_image for softpipe.
> ---
>  src/gallium/drivers/softpipe/sp_screen.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c
> index 817572c..4cd8581 100644
> --- a/src/gallium/drivers/softpipe/sp_screen.c
> +++ b/src/gallium/drivers/softpipe/sp_screen.c
> @@ -243,8 +243,9 @@ softpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_RESOURCE_FROM_USER_MEMORY:
>     case PIPE_CAP_DEVICE_RESET_STATUS_QUERY:
>     case PIPE_CAP_MAX_SHADER_PATCH_VARYINGS:
> -   case PIPE_CAP_COPY_IMAGE:
>        return 0;
> +   case PIPE_CAP_COPY_IMAGE:
> +      return 1;
>     }
>     /* should only get here on unhandled cases */
>     debug_printf("Unexpected PIPE_CAP %d query\n", param);
> --
> 1.9.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list