[Mesa-dev] [PATCH 8/9] softpipe: enable PIPE_CAP_COPY_IMAGE

[Brian Paul]

On 08/27/2015 06:01 PM, Ilia Mirkin wrote:
> Are you sure you want to enable it in spite of the fact that it
> doesn't handle swizzling (which you've slightly papered over by
> switching some of the format orders around, but as I pointed out not
> completely)?

As I said before, I'd like to get as much of this committed as possible 
with the understanding that there's more work to do.  If you really feel 
that softpipe/llvmpipe should not have this feature, I guess I could 
drop it, but I'd rather not.

-Brian

>
> On Thu, Aug 27, 2015 at 7:48 PM, Brian Paul <brianp at vmware.com> wrote:
>> This enables GL_ARB_copy_image for softpipe.
>> ---
>>   src/gallium/drivers/softpipe/sp_screen.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c
>> index 817572c..4cd8581 100644
>> --- a/src/gallium/drivers/softpipe/sp_screen.c
>> +++ b/src/gallium/drivers/softpipe/sp_screen.c
>> @@ -243,8 +243,9 @@ softpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>>      case PIPE_CAP_RESOURCE_FROM_USER_MEMORY:
>>      case PIPE_CAP_DEVICE_RESET_STATUS_QUERY:
>>      case PIPE_CAP_MAX_SHADER_PATCH_VARYINGS:
>> -   case PIPE_CAP_COPY_IMAGE:
>>         return 0;
>> +   case PIPE_CAP_COPY_IMAGE:
>> +      return 1;
>>      }
>>      /* should only get here on unhandled cases */
>>      debug_printf("Unexpected PIPE_CAP %d query\n", param);
>> --
>> 1.9.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=BQIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=boWEzJZq3R1bwOyXXwKjY_zAq4bCwY1jdfpSoGw9IBQ&s=X-NiXvm30sqKilGdGtp81E3uQtO42r1SS9gHxjUxhDs&e=