[Mesa-dev] [PATCH 4/7] gallium/winsys: Make use of ARRAY_SIZE macro

Emil Velikov emil.l.velikov at gmail.com
Fri Dec 4 06:33:58 PST 2015


Hi Edward,

A few trivial suggestions (for future patches) and a humble request

On 4 December 2015 at 06:50, Edward O'Callaghan
<eocallaghan at alterapraxis.com> wrote:
> Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
> ---
>  src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 6 ++----
For the patches do shorten up the prefix - here we'd want
"winsys/amdgpu" while on the driver side just "nouveau" or "llvmpipe"
should suffice. When in doubt git log is your friend

You mentioned that you've done these with a Coccinelle schematic patch
(script) - mind if we get that (actually start collecting) in tree ...
perhaps in bin/ or bin/cocci/ ?

Thanks
Emil


More information about the mesa-dev mailing list