[Mesa-dev] [PATCH 4/7] gallium/winsys: Make use of ARRAY_SIZE macro

eocallaghan at alterapraxis.com eocallaghan at alterapraxis.com
Fri Dec 4 09:37:15 PST 2015

On 2015-12-05 01:33, Emil Velikov wrote:
> Hi Edward,
> A few trivial suggestions (for future patches) and a humble request
> On 4 December 2015 at 06:50, Edward O'Callaghan
> <eocallaghan at alterapraxis.com> wrote:
>> Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
>> ---
>>  src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 6 ++----
> For the patches do shorten up the prefix - here we'd want
> "winsys/amdgpu" while on the driver side just "nouveau" or "llvmpipe"
> should suffice. When in doubt git log is your friend

Sure no worries, will do on future patches. Thanks.

> You mentioned that you've done these with a Coccinelle schematic patch
> (script) - mind if we get that (actually start collecting) in tree ...
> perhaps in bin/ or bin/cocci/ ?

Definitely! This is in fact part of my proposed plan after I get some of
the major churn out the way and see what passes review and hence which
.cocci scripts are suitable for mesa.

> Thanks
> Emil

Kind Regards,

More information about the mesa-dev mailing list