[Mesa-dev] [PATCH] st/mesa: Don't apply multsample FB rasterization to non-multisample FBs.

[Ilia Mirkin]

On Fri, Dec 11, 2015 at 3:37 PM, Eric Anholt <eric at anholt.net> wrote:
> It's not just whether GL_MULTISAMPLE is 1 that determines if multisample
> framebuffer operations happen, it's also whether SAMPLE_BUFFERS > 1.
> Noticed with my broken sample_mask support when ETQW traces that were only
> using a single sampled buffer crashed.
> ---
>  src/mesa/state_tracker/st_atom_blend.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_atom_blend.c b/src/mesa/state_tracker/st_atom_blend.c
> index 6bb4077..812b2a7 100644
> --- a/src/mesa/state_tracker/st_atom_blend.c
> +++ b/src/mesa/state_tracker/st_atom_blend.c
> @@ -265,7 +265,7 @@ update_blend( struct st_context *st )
>
>     blend->dither = ctx->Color.DitherFlag;
>
> -   if (ctx->Multisample.Enabled) {
> +   if (ctx->Multisample._Enabled) {

Does this need _NEW_BUFFERS in the atom definition then?

>        /* unlike in gallium/d3d10 these operations are only performed
>           if msaa is enabled */
>        blend->alpha_to_coverage = ctx->Multisample.SampleAlphaToCoverage;
> --
> 2.6.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev