[Mesa-dev] [PATCH] st/mesa: Don't apply multsample FB rasterization to non-multisample FBs.

[Eric Anholt]

Ilia Mirkin <imirkin at alum.mit.edu> writes:

> On Fri, Dec 11, 2015 at 3:37 PM, Eric Anholt <eric at anholt.net> wrote:
>> It's not just whether GL_MULTISAMPLE is 1 that determines if multisample
>> framebuffer operations happen, it's also whether SAMPLE_BUFFERS > 1.
>> Noticed with my broken sample_mask support when ETQW traces that were only
>> using a single sampled buffer crashed.
>> ---
>>  src/mesa/state_tracker/st_atom_blend.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/state_tracker/st_atom_blend.c b/src/mesa/state_tracker/st_atom_blend.c
>> index 6bb4077..812b2a7 100644
>> --- a/src/mesa/state_tracker/st_atom_blend.c
>> +++ b/src/mesa/state_tracker/st_atom_blend.c
>> @@ -265,7 +265,7 @@ update_blend( struct st_context *st )
>>
>>     blend->dither = ctx->Color.DitherFlag;
>>
>> -   if (ctx->Multisample.Enabled) {
>> +   if (ctx->Multisample._Enabled) {
>
> Does this need _NEW_BUFFERS in the atom definition then?

Good point.  I'll fix that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151211/611b1532/attachment.sig>