[Mesa-dev] [PATCH 1/6] main: Added entry point for glCreateTransformFeedbacks

Martin Peres martin.peres at linux.intel.com
Tue Feb 3 07:52:30 PST 2015


On 02/02/15 23:36, Laura Ekstrand wrote:
> On Mon, Feb 2, 2015 at 2:58 AM, Martin Peres 
> <martin.peres at linux.intel.com <mailto:martin.peres at linux.intel.com>> 
> wrote:
>
>               if (!obj) {
>     -            _mesa_error(ctx, GL_OUT_OF_MEMORY,
>     "glGenTransformFeedbacks");
>     +            _mesa_error(ctx, GL_OUT_OF_MEMORY, "%s", func);
>
>                 ^^
> This doesn't line up with ( above.  Mesa uses 3-space identation.
Seems like a visualisation problem as the indentation was good before 
the patch and is still good after it...
>
>                  return;
>               }
>     -         names[i] = first + i;
>     +         ids[i] = first + i;
>
> Same thing

Same thing
>
>     _mesa_HashInsert(ctx->TransformFeedback.Objects, first + i, obj);
>     +         if (dsa) {
>     +            /* this is normally done at bind time in the non-dsa
>     case */
>     +            obj->EverBound = GL_TRUE;
>     +         }
>            }
>         }
>         else {
>     -      _mesa_error(ctx, GL_OUT_OF_MEMORY, "glGenTransformFeedbacks");
>     +      _mesa_error(ctx, GL_OUT_OF_MEMORY, "%s", func);
>
> Same thing.

Same thing.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150203/d4adf374/attachment.html>


More information about the mesa-dev mailing list