[Mesa-dev] [PATCH 3/6] main: Added entry point for glTransformFeedbackBufferRange
Martin Peres
martin.peres at linux.intel.com
Tue Feb 3 08:26:49 PST 2015
On 02/02/15 23:51, Laura Ekstrand wrote:
>
> On Mon, Feb 2, 2015 at 3:30 AM, Martin Peres
> <martin.peres at linux.intel.com <mailto:martin.peres at linux.intel.com>>
> wrote:
>
> if (index >= ctx->Const.MaxTransformFeedbackBuffers) {
> - _mesa_error(ctx, GL_INVALID_VALUE,
> "glBindBufferRange(index=%d "
> - "out of bounds)", index);
> + /* An INVALID_VALUE error is generated if index is greater
> than or equal
> + * to the number of binding points for transform feedback,
> as described
> + * in section 6.7.1.
>
> Include the spec ^^^^ (I presume OpenGL 4.5 core).
Done, thanks
> + */
> + _mesa_error(ctx, GL_INVALID_VALUE, "%s(index=%d out of
> bounds)",
> + gl_methd_name, index);
> return;
> }
>
> if (size & 0x3) {
> - /* must a multiple of four */
> - _mesa_error(ctx, GL_INVALID_VALUE,
> "glBindBufferRange(size=%d)",
> - (int) size);
> + /* must a be multiple of four */
> + _mesa_error(ctx, GL_INVALID_VALUE, "%s(size=%d must be a
> multiple of "
> + "four)", gl_methd_name, (int) size);
> return;
> }
>
> if (offset & 0x3) {
> /* must be multiple of four */
> - _mesa_error(ctx, GL_INVALID_VALUE,
> - "glBindBufferRange(offset=%d)", (int) offset);
> + _mesa_error(ctx, GL_INVALID_VALUE, "gl%s(offset=%d must be
> a multiple "
> + "of four)", gl_methd_name, (int) offset);
> return;
> - }
> + }
> +
> + if (offset < 0) {
> + /* An INVALID_VALUE error is generated by BindBufferRange
> if buffer is
> + * non-zero and size is less than or equal to zero.
>
> They're still mixed up. ^^ It says size instead of offset.
I'm so sorry! I fixed it properly now!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150203/7ced792d/attachment-0001.html>
More information about the mesa-dev
mailing list