[Mesa-dev] [PATCH 2/4] mesa: introduce the equivalent of MESA_EXTENSION_OVERRIDE in drirc v2

[Ian Romanick]

On 02/06/2015 12:20 PM, Martin Peres wrote:
> On 03/02/15 18:27, Ilia Mirkin wrote:
>> On Tue, Feb 3, 2015 at 10:41 AM, Martin Peres
>> <martin.peres at linux.intel.com> wrote:
>>> When both MESA_EXTENSION_OVERRIDE and drirc's mesa_extension_override
>>> are
>>> set, the environment variable takes precedence.
>> Just a thought -- combine them instead of having one override the
>> other? (With the env var being processed second so that it can
>> override things in the drirc.
> 
> That kind of was my first thought, but I kind of hate when part of the
> state is not visible. If we implement this, then the user would have to
> know what is in the drirc to be sure it does the right thing. On the
> other hand, with the current system, setting the environment variable
> will make games with workarounds not work anymore. I guess this is a
> pick your poison situation but I prefer the current one.
> 
> If people think your proposition is better, I can have a look at it and
> see how mesa would react to a situation like -FOO +FOO. As there are two
> lists right now to keep track of the added and removed extensions, I
> guess one takes precedence on the other. I guess I would have to remove
> extensions from one list before adding it to the other.

I think we should have the env variable take precedence.  Since you can
also set driconf variables in the environment, at some point in the
future we should remove MESA_EXTENSION_OVERRIDE.

>> OTOH drirc settings are also overridable via env var (as I recall), so
>> someone could use a mesa_extension_override env var (in addition to a
>> MESA_EXTENSION_OVERRIDE env var).
> 
> Really? I'll have a look into this! If this is the case, then I guess it
> could be an argument in favour of your proposition :)
>>
>> Anyways, just wanted to point out the possibility, in case you liked
>> the idea.
> 
> Thanks :)
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev