[Mesa-dev] [PATCH] mesa: Update layered state when attaching a renderbuffer

Chris Forbes chrisf at ijw.co.nz
Sat Feb 7 16:50:41 PST 2015


Apologies -- I'd not noticed that there was an equivalent patch
already attached to the bug report.

In that case, James Legg's patch is:

Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>

(and I'll push it shortly)

On Sun, Feb 8, 2015 at 1:47 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:
> Renderbuffers are never layered. Previously we'd just leave whatever
> value was present from the previous attachment.
>
> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89026
> ---
>  src/mesa/main/fbobject.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index 3305151..dae9d4e 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -468,6 +468,7 @@ set_renderbuffer_attachment(struct gl_context *ctx,
>     remove_attachment(ctx, att);
>     att->Type = GL_RENDERBUFFER_EXT;
>     att->Texture = NULL; /* just to be safe */
> +   att->Layered = GL_FALSE;
>     att->Complete = GL_FALSE;
>     _mesa_reference_renderbuffer(&att->Renderbuffer, rb);
>  }
> --
> 2.2.2
>


More information about the mesa-dev mailing list