[Mesa-dev] [PATCH 2/2] i965/vec4: Emit MADs from (x + abs(y * z)).

Kenneth Graunke kenneth at whitecape.org
Mon Feb 9 16:38:17 PST 2015


On Friday, January 30, 2015 06:33:28 PM Matt Turner wrote:
> Same as commit 3654b6d4 to the fs backend.
> 
> total instructions in shared programs: 5945788 -> 5945787 (-0.00%)
> instructions in affected programs:     36 -> 35 (-2.78%)
> helped:                                1
> ---
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> index 87d4960..1e32856 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> @@ -1172,8 +1172,11 @@ vec4_visitor::try_emit_mad(ir_expression *ir)
>     ir_rvalue *nonmul = ir->operands[1];
>     ir_expression *mul = ir->operands[0]->as_expression();
>  
> -   bool mul_negate = false;
> -   if (mul && mul->operation == ir_unop_neg) {
> +   bool mul_negate = false, mul_abs = false;;

Double ;;

Both patches are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150209/ab441361/attachment.sig>


More information about the mesa-dev mailing list