[Mesa-dev] [PATCH] nir/lower_phis_to_scalar: Fix some logic in is_phi_scalarizable

Kenneth Graunke kenneth at whitecape.org
Wed Feb 11 10:47:56 PST 2015


On Monday, February 09, 2015 02:23:25 PM Jason Ekstrand wrote:
> ---
>  src/glsl/nir/nir_lower_phis_to_scalar.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c b/src/glsl/nir/nir_lower_phis_to_scalar.c
> index 3bb5cc7..7cd93ea 100644
> --- a/src/glsl/nir/nir_lower_phis_to_scalar.c
> +++ b/src/glsl/nir/nir_lower_phis_to_scalar.c
> @@ -65,9 +65,9 @@ is_phi_src_scalarizable(nir_phi_src *src,
>         * are ok too.
>         */
>        return nir_op_infos[src_alu->op].output_size == 0 ||
> -             src_alu->op != nir_op_vec2 ||
> -             src_alu->op != nir_op_vec3 ||
> -             src_alu->op != nir_op_vec4;
> +             src_alu->op == nir_op_vec2 ||
> +             src_alu->op == nir_op_vec3 ||
> +             src_alu->op == nir_op_vec4;
>     }
>  
>     case nir_instr_type_phi:
> 

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150211/1106a4a8/attachment.sig>


More information about the mesa-dev mailing list