[Mesa-dev] [PATCH 05/11] mesa: Fix error validating args for TexSubImage3D

[Ian Romanick]

On 02/10/2015 08:12 AM, Brian Paul wrote:
> On 02/10/2015 08:40 AM, Eduardo Lima Mitev wrote:
>> The zoffset and depth values were not being considered when calling
>> error_check_subtexture_dimensions().
>>
>> Fixes 2 dEQP tests:
>> * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_neg_offset
>> * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_invalid_offset
>> ---
>>   src/mesa/main/teximage.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
>> index 29c325b..c9c48bb 100644
>> --- a/src/mesa/main/teximage.c
>> +++ b/src/mesa/main/teximage.c
>> @@ -2491,8 +2491,8 @@ texsubimage_error_check(struct gl_context *ctx,
>> GLuint dimensions,
>>      }
>>
>>      if (error_check_subtexture_dimensions(ctx, dimensions,
>> -                                         texImage, xoffset, yoffset, 0,
>> -                                         width, height, 1,
>> +                                         texImage, xoffset, yoffset,
>> zoffset,
>> +                                         width, height, depth,
>>                                            dsa ? "glTextureSubImage" :
>>                                            "glTexSubImage")) {
>>         return GL_TRUE;
>>
> 
> Reviewed-by: Brian Paul <brianp at vmware.com>
> 
> This could probably be tagged for the 10.4 and 10.5 stable branches too.

Agreed.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev