[Mesa-dev] [PATCH] glsl: Use the without_array predicate

Matt Turner mattst88 at gmail.com
Thu Feb 19 13:18:05 PST 2015


On Thu, Feb 19, 2015 at 11:57 AM, Timothy Arceri <t_arceri at yahoo.com.au> wrote:
> ---
>  src/glsl/ir.h | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/src/glsl/ir.h b/src/glsl/ir.h
> index a0f48b2..9c60b07 100644
> --- a/src/glsl/ir.h
> +++ b/src/glsl/ir.h
> @@ -450,11 +450,8 @@ public:
>      */
>     inline bool is_interface_instance() const
>     {
> -      const glsl_type *const t = this->type;
> -
> -      return (t == this->interface_type)
> -         || (t->is_array() && t->fields.array == this->interface_type);
> -    }
> +      return (this->type->without_array() == this->interface_type);

Remove the superfluous parentheses, and

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list