[Mesa-dev] [PATCH] glsl/fp64: disable varying packing for doubles. (v2)

[Marek Olšák]

Hi Dave,

I think transform feedback doesn't work without the varying packing.
Cc'ing Paul Berry.

Marek

On Fri, Feb 20, 2015 at 5:03 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> I'm not sure we really care about this, but we need to
> write better support if we do. For now just disable it.
>
> piglit test: tests/spec/arb_gpu_shader_fp64/execution/vs-out-fs-in-double-2.shader_test
>
> v2: move code down below to avoid getting array type.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/glsl/lower_packed_varyings.cpp | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/glsl/lower_packed_varyings.cpp b/src/glsl/lower_packed_varyings.cpp
> index 5e844c7..83b70f9 100644
> --- a/src/glsl/lower_packed_varyings.cpp
> +++ b/src/glsl/lower_packed_varyings.cpp
> @@ -598,6 +598,9 @@ lower_packed_varyings_visitor::needs_lowering(ir_variable *var)
>     }
>     if (type->is_array())
>        type = type->fields.array;
> +   /* don't attempt to pack double varyings yet */
> +   if (type->base_type == GLSL_TYPE_DOUBLE)
> +      return false;
>     if (type->vector_elements == 4)
>        return false;
>     return true;
> --
> 1.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev