[Mesa-dev] [PATCH] mesa: Adds missing error condition in _mesa_check_sample_count()

Martin Peres martin.peres at linux.intel.com
Mon Feb 23 00:48:11 PST 2015


On 23/02/15 10:33, Eduardo Lima Mitev wrote:
> Hi, can someone take a look? It should be very straight forward.
>
> Eduardo
You are not supposed to return INVALID_OPERATION if samples < 0.

Also, samples == 0 is valid [0], so this is a NAK for me! The correct patch
has already been posted to the ML:
[PATCH 03/16] main: fix the validation of the number of samples

[0]: 
http://cgit.freedesktop.org/mesa/mesa/tree/src/mesa/main/fbobject.c#n1804


More information about the mesa-dev mailing list