[Mesa-dev] [PATCH] mesa: Adds missing error condition in _mesa_check_sample_count()

Eduardo Lima Mitev elima at igalia.com
Mon Feb 23 01:24:47 PST 2015

On 02/23/2015 09:48 AM, Martin Peres wrote:
> On 23/02/15 10:33, Eduardo Lima Mitev wrote:
>> Hi, can someone take a look? It should be very straight forward.
>> Eduardo
> You are not supposed to return INVALID_OPERATION if samples < 0.
> Also, samples == 0 is valid [0], so this is a NAK for me! The correct patch
> has already been posted to the ML:
> [PATCH 03/16] main: fix the validation of the number of samples

Hi Martin,

this is a different error check, coming from this wording:

Section 4.4 (Framebuffer objects), page 198 of the OpenGL 3.0.0
specification says:

    "If internalformat is a signed or unsigned integer format and
     samples is greater than zero, then the error INVALID_OPERATION
     is generated."

See the original patch 19252fee46b835cb4f6b1cce18d7737d62b64a2e which
missed the check for samples being greater than zero:


More information about the mesa-dev mailing list